Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

[Durability] Should not allow user to set timeout value greater than the KV supported value

Description

Durability timeout is sent in milliseconds, but has a type of 'int'.

So sdk_timeout more than 70 seconds cannot be tested.

Environment

2.0.0-alpha3

Gerrit Reviews

None

Release Notes Description

None

Attachments

1
  • 14 Jun 2019, 09:29 AM

Activity

Show:

Michael Nitschinger June 21, 2019 at 5:03 PM

Ok, we'll add warn level logging/event when this happens.

Matt Ingenthron June 21, 2019 at 4:58 PM

I'm good with option 2, and I think we should log a warning and document it well. Agreed that it's really long.

Michael Nitschinger June 21, 2019 at 4:38 PM

logging a warning sounds okay, but then on the other hand logging for every request might also be super spammy?

Michael Nitschinger June 20, 2019 at 5:47 PM

Right now we do option 2 without the logging. I feel that this might be the better option than 1, because 65s is a LONG time anyways for a kv timeout.

Matt Ingenthron June 20, 2019 at 5:15 PM

It seems there are two options:
1) Reject it with an InvalidArgumentException or such, make sure it's covered in the docs.
2) Coerce it to the possible max and log a warning.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Story Points

Fix versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created June 14, 2019 at 9:32 AM
Updated April 24, 2020 at 8:55 PM
Resolved October 11, 2019 at 4:25 PM
Instabug