Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-253

flush_all method still available through API, does nothing against 2.0 cluster

    Details

    • Type: Bug
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 1.2.4
    • Fix Version/s: backlog-1.0
    • Component/s: docs, library
    • Labels:
      None

      Description

      Is flush_all deprecated for 2.x clusters? No error is returned when run against a 2.0 bucket

      Need SDK documentation on the deprecation and how to use flush properly (it's currently only in the release notes)

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        john John Zablocki (Inactive) added a comment -

        FlushAll is a method on the Enyim MemchacedClient, so it's inherited.

        I've posted a change to Gerrit that checks to see if any of the working nodes is of type CouchbaseNode (2.0+). If so, an NotImplementedException is raised. Otherwise, if it's a Memcached bucket or 1.8.x, the MemcachedClient.FlushAll is performed.

        Show
        john John Zablocki (Inactive) added a comment - FlushAll is a method on the Enyim MemchacedClient, so it's inherited. I've posted a change to Gerrit that checks to see if any of the working nodes is of type CouchbaseNode (2.0+). If so, an NotImplementedException is raised. Otherwise, if it's a Memcached bucket or 1.8.x, the MemcachedClient.FlushAll is performed.
        Hide
        john John Zablocki (Inactive) added a comment -

        Would this approach address your concern?

        Show
        john John Zablocki (Inactive) added a comment - Would this approach address your concern?
        Hide
        perry Perry Krug added a comment -

        Sounds very reasonable to me, thank you.

        Show
        perry Perry Krug added a comment - Sounds very reasonable to me, thank you.
        Hide
        ingenthr Matt Ingenthron added a comment -

        Should it perform a RESTful flush if the server is a 2.0 server && couchbase bucket? This is what we did in the Java client if I recall correctly. The logic being this way code moves over and just works.

        Show
        ingenthr Matt Ingenthron added a comment - Should it perform a RESTful flush if the server is a 2.0 server && couchbase bucket? This is what we did in the Java client if I recall correctly. The logic being this way code moves over and just works.
        Hide
        john John Zablocki (Inactive) added a comment -

        Is that the right API? To me it feels like it isn't, since flush is no longer a "client" API action. It's easy enough to implement, but seems best to steer people to the right API, imo...

        Show
        john John Zablocki (Inactive) added a comment - Is that the right API? To me it feels like it isn't, since flush is no longer a "client" API action. It's easy enough to implement, but seems best to steer people to the right API, imo...

          People

          • Assignee:
            jmorris Jeff Morris
            Reporter:
            perry Perry Krug
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Gerrit Reviews

              There are no open Gerrit changes