Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-2905

ThresholdLoggingTracer should omit null values

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.1.7
    • 3.2.0
    • None
    • 1

    Description

      On master the format looks like the following:

       {
            "total_duration_us":95,
            "encode_duration_us":27,
            "last_dispatch_duration_us":18,
            "total_dispatch_duration_us":40,
            "last_server_duration_us":null,
            "total_server_duration_us":null,
            "operation_name":"get",
            "last_local_id":"2",
            "operation_id":"85414",
            "last_local_socket":"127.0.0.1:11210:56218",
            "last_remote_socket":"127.0.0.1:11210:56218"
      }
      

      The RFC mentions that fields should only be added if present, so if a field is null (as the server duration) here it should be omitted instead of printing it with null.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          There are no comments yet on this issue.

          People

            jmorris Jeff Morris
            daschl Michael Nitschinger
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty