Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-3387

Remove Internal keword from ICollectionQueryIndexManager

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 3.4.12
    • None
    • None
    • None
    • 0
    • SDK36

    Description

      The interface ICollectionQueryIndexManager contains the internal keyword

      ICollectionQueryIndexManager
      /// <summary>
      /// An internal collection reference for the query_context.
      /// </summary>
      internal ICouchbaseCollection Collection { get; set; }
       
      /// <summary>
      /// An internal scope reference for the query_context.
      /// </summary>
      internal IBucket Bucket { get; set; }
      

      This is very bad for testing with mock for projects not being friend assemblies. There is no way to implement such an interface from the outside world.

      Insted think about splitting the Interface into two parts a internal and external one

      Attachments

        For Gerrit Dashboard: NCBC-3387
        # Subject Branch Project Status CR V

        Activity

          People

            jmorris Jeff Morris
            pklein Patric Klein
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty