Uploaded image for project: 'Couchbase .NET client library'
  1. Couchbase .NET client library
  2. NCBC-3709

Metrics are timed separately for each retry

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 3.5.0
    • 3.4.15
    • library
    • None
    • 0

    Description

      The Metrics RFC (https://docs.google.com/document/d/1BAPS8bPMv8-4FPIdysgpxEsKrUgd595EAGOU-_nXHRY/edit?pli=1#heading=h.68c8u56woaes) states that operation duration metrics should be measured surrounding the entire operation attempt, including retries.

      Response Latency in microseconds  which covers the complete request / response cycle (think: “outer request span latency”, covering encode, dispatch, retries etc). Note: for bulk operations, each individual request counts individually.
       
      Instrumented at: when the response has been decoded, before it is marked as completed towards the user
      

      Currently, the .NET SDK is measuring and reporting metrics for each attempt when there are retries. There appears to be some logic that is "summing" the attempts, I'm not sure precisely what that is doing, but is definitely outputting a value for each attempt regardless.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            btburnett3 Brant Burnett
            btburnett3 Brant Burnett
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty