Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-127

Make negative expiry times be E_RECOVERABLE_ERROR instead of E_ERROR

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0-dp5
    • Fix Version/s: 1.1.0-dp5
    • Component/s: library
    • Security Level: Public
    • Labels:
      None

      Description

      The error raised by negative expiry times should be E_RECOVERABLE_ERROR instead of E_ERROR, based on discussion in #libcouchbase. Operationally they have the same effect (fatal error), but the former can be caught by user-defined error handler functions. That is handy for example in testing.

      Per discussion with Mark, this should be a child of http://review.couchbase.org/#/c/21236/ when the changeset is developed.

      (This is a one-line change in the _check_expiry function, changing the error code given to php_error.)

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        mjackson Michael Jackson added a comment -

        http://review.couchbase.org/#/c/21236/ has been updated with change mentioned above.

        Show
        mjackson Michael Jackson added a comment - http://review.couchbase.org/#/c/21236/ has been updated with change mentioned above.
        Hide
        mjackson Michael Jackson added a comment -

        After further discussion, this was rolled into PCBC-51's changeset instead.

        Show
        mjackson Michael Jackson added a comment - After further discussion, this was rolled into PCBC-51 's changeset instead.
        Hide
        mjackson Michael Jackson added a comment -
        Show
        mjackson Michael Jackson added a comment - http://review.couchbase.org/#/c/21320/1 has this change
        Hide
        mjackson Michael Jackson added a comment -

        pcbc-51 changeset merged to master. (51 is tentatively still open because I'm not sure if that needs to also be backported to 1.0.x)

        Show
        mjackson Michael Jackson added a comment - pcbc-51 changeset merged to master. (51 is tentatively still open because I'm not sure if that needs to also be backported to 1.0.x)

          People

          • Assignee:
            mjackson Michael Jackson
            Reporter:
            mjackson Michael Jackson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes