Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-127

Make negative expiry times be E_RECOVERABLE_ERROR instead of E_ERROR

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 1.1.0-dp5
    • 1.1.0-dp5
    • library
    • Security Level: Public
    • None

    Description

      The error raised by negative expiry times should be E_RECOVERABLE_ERROR instead of E_ERROR, based on discussion in #libcouchbase. Operationally they have the same effect (fatal error), but the former can be caught by user-defined error handler functions. That is handy for example in testing.

      Per discussion with Mark, this should be a child of http://review.couchbase.org/#/c/21236/ when the changeset is developed.

      (This is a one-line change in the _check_expiry function, changing the error code given to php_error.)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            mjackson Michael Jackson
            mjackson Michael Jackson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty