Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-155

Compile error at git:master 2f51ee9573cc93fdf343570ac5422bb99f6ce7f6

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: Public
    • Labels:
      None

      Description

      Probably a temporary error, but I updated from git this morning to recompile and I'm getting this:

      /root/sources/php-ext-couchbase/remove.c: In function 'php_couchbase_remove_callback':
      /root/sources/php-ext-couchbase/remove.c:16: error: 'const struct <anonymous>' has no member named 'cas'
      make: *** [remove.lo] Error 1

      And the end of the make process. PHP 5.3.19, CentOS5.6. Let me know if you need any more specific system information.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Show
        chuyskywalker Jeff Minard added a comment - This commit https://github.com/couchbase/php-ext-couchbase/commit/ad692a4f28f031ff02385f1985e45f0b17a39d87 introduced the error.
        Hide
        ingenthr Matt Ingenthron added a comment -

        Thanks Jeff! We'll let you know if we need more info. If you can, please "git clean -dfx" (brutal clean) as I've had things stick around and cause problems before.

        Trond: can you check this out?

        Show
        ingenthr Matt Ingenthron added a comment - Thanks Jeff! We'll let you know if we need more info. If you can, please "git clean -dfx" (brutal clean) as I've had things stick around and cause problems before. Trond: can you check this out?
        Hide
        trond Trond Norbye added a comment -

        You have to upgrade libcouchbase to the latest 2.0 release

        Show
        trond Trond Norbye added a comment - You have to upgrade libcouchbase to the latest 2.0 release
        Hide
        ingenthr Matt Ingenthron added a comment -

        Thanks Trond. Do you think we should add some checks for a 2.0 lcb and print out a sane error message?

        Show
        ingenthr Matt Ingenthron added a comment - Thanks Trond. Do you think we should add some checks for a 2.0 lcb and print out a sane error message?
        Hide
        trond Trond Norbye added a comment -

        That's easier said than done.. this changed with some of the betas... it is going to be pretty much work to always keep that up to date (and backport fixes etc)

        Show
        trond Trond Norbye added a comment - That's easier said than done.. this changed with some of the betas... it is going to be pretty much work to always keep that up to date (and backport fixes etc)
        Hide
        chuyskywalker Jeff Minard added a comment - - edited

        > You have to upgrade libcouchbase to the latest 2.0 release

        How does one go about that? I had installed libcouchbase from the rhel5x64 repo (specifically http://packages.couchbase.com/preview/rpm/5.5/x86_64) – is the repo not going to be up-to-date enough?

        Show
        chuyskywalker Jeff Minard added a comment - - edited > You have to upgrade libcouchbase to the latest 2.0 release How does one go about that? I had installed libcouchbase from the rhel5x64 repo (specifically http://packages.couchbase.com/preview/rpm/5.5/x86_64 ) – is the repo not going to be up-to-date enough?
        Hide
        ingenthr Matt Ingenthron added a comment -

        If it's the preview repo, then it should be up to date. Have you done a "yum update" (I think it is)? Which lcb does RPM/yum say you have installed right now?

        That said, libcouchbase is actually released, so you can actually move to the release repo. When I had to do this recently, I had to clean my yum cache with "yum clean all" IIRC. in order to get the latest bits.

        Show
        ingenthr Matt Ingenthron added a comment - If it's the preview repo, then it should be up to date. Have you done a "yum update" (I think it is)? Which lcb does RPM/yum say you have installed right now? That said, libcouchbase is actually released, so you can actually move to the release repo. When I had to do this recently, I had to clean my yum cache with "yum clean all" IIRC. in order to get the latest bits.
        Hide
        chuyskywalker Jeff Minard added a comment -

        Yup, updating the repo did the trick. I'll give switching over the to the release repo a try too. That would be http://packages.couchbase.com/rpm/couchbase-centos55-x86_64.repo correct?

        Thanks guys!

        Show
        chuyskywalker Jeff Minard added a comment - Yup, updating the repo did the trick. I'll give switching over the to the release repo a try too. That would be http://packages.couchbase.com/rpm/couchbase-centos55-x86_64.repo correct? Thanks guys!
        Hide
        chuyskywalker Jeff Minard added a comment -

        Updating to the real repo is failing, but not for other reasons I'll address over here: http://www.couchbase.com/issues/browse/PCBC-155

        Show
        chuyskywalker Jeff Minard added a comment - Updating to the real repo is failing, but not for other reasons I'll address over here: http://www.couchbase.com/issues/browse/PCBC-155
        Hide
        ingenthr Matt Ingenthron added a comment -

        Well, now I've run into this myself. It looks like something changed between beta3 and release on libcouchbase Same building problem Jeff had.

        Show
        ingenthr Matt Ingenthron added a comment - Well, now I've run into this myself. It looks like something changed between beta3 and release on libcouchbase Same building problem Jeff had.
        Hide
        trond Trond Norbye added a comment -

        That is a risk dealing with previews or betas.

        Show
        trond Trond Norbye added a comment - That is a risk dealing with previews or betas.
        Hide
        ingenthr Matt Ingenthron added a comment -

        This is true, but we shouldn't have changed API/ABI between beta3 and GA. Apparently something changed.

        Show
        ingenthr Matt Ingenthron added a comment - This is true, but we shouldn't have changed API/ABI between beta3 and GA. Apparently something changed.
        Hide
        trond Trond Norbye added a comment -

        The change was necessary in order to be able to support observe on deleted items. Personally I don't think this is a big deal since it was all sorted out on for the GA. If we can't fix up missing pieces between betas and GA we'll end up with a million different APIs for things just because we can't clean up stuff..

        Show
        trond Trond Norbye added a comment - The change was necessary in order to be able to support observe on deleted items. Personally I don't think this is a big deal since it was all sorted out on for the GA. If we can't fix up missing pieces between betas and GA we'll end up with a million different APIs for things just because we can't clean up stuff..
        Hide
        ingenthr Matt Ingenthron added a comment -

        We can, but it should be exceptional and something that's communicated. It also means that we need to ship updates so we don't leave people broken. It's unfortunately not always trivial to get the older one, even if you know you need it.

        We'll work through it-- we just need to be more disciplined between Beta and GA, otherwise Beta is no different than Dev Preview.

        Show
        ingenthr Matt Ingenthron added a comment - We can, but it should be exceptional and something that's communicated. It also means that we need to ship updates so we don't leave people broken. It's unfortunately not always trivial to get the older one, even if you know you need it. We'll work through it-- we just need to be more disciplined between Beta and GA, otherwise Beta is no different than Dev Preview.

          People

          • Assignee:
            trond Trond Norbye
            Reporter:
            chuyskywalker Jeff Minard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes