Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: library
    • Security Level: Public
    • Labels:
      None

      Description

      viewopts.c appears to be missing include_docs as a valid parameter for the array values that get passed in for a view.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        chuyskywalker Jeff Minard added a comment -

        I just added

        1. git diff
          diff --git a/viewopts.c b/viewopts.c
          index 612559d..4b9ce0f 100644
            • a/viewopts.c
              +++ b/viewopts.c
              @@ -54,6 +54,7 @@ static view_param Recognized_View_Params[] =
              Unknown macro: { { "startkey", jval_param_handler }, { "startkey_docid", string_param_handler }, { "debug", bool_param_handler },+ { "include_docs", bool_param_handler }, { NULL, NULL } }

              ;

        And it seems to work just fine.

        Show
        chuyskywalker Jeff Minard added a comment - I just added git diff diff --git a/viewopts.c b/viewopts.c index 612559d..4b9ce0f 100644 a/viewopts.c +++ b/viewopts.c @@ -54,6 +54,7 @@ static view_param Recognized_View_Params[] = Unknown macro: { { "startkey", jval_param_handler }, { "startkey_docid", string_param_handler }, { "debug", bool_param_handler },+ { "include_docs", bool_param_handler }, { NULL, NULL } } ; And it seems to work just fine.
        Hide
        brett19 Brett Lawson added a comment -

        Matt: Do you see any issue with adding include_docs as above, or should we be internally doing a batched get on the results.

        Show
        brett19 Brett Lawson added a comment - Matt: Do you see any issue with adding include_docs as above, or should we be internally doing a batched get on the results.
        Hide
        trond Trond Norbye added a comment -

        Include docs should not be passed to the server, but handled internally in the library fetching the documents over the data connection to the cluster.

        Show
        trond Trond Norbye added a comment - Include docs should not be passed to the server, but handled internally in the library fetching the documents over the data connection to the cluster.
        Hide
        brett19 Brett Lawson added a comment -

        This issue does not present itself with the 2.0 SDKs.

        Show
        brett19 Brett Lawson added a comment - This issue does not present itself with the 2.0 SDKs.

          People

          • Assignee:
            brett19 Brett Lawson
            Reporter:
            chuyskywalker Jeff Minard
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes