Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-192

Persistent connections should be the default

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.2
    • Fix Version/s: 1.2.0
    • Component/s: library
    • Security Level: Public
    • Labels:
      None

      Attachments

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        mnunberg Mark Nunberg (Inactive) added a comment -

        I don't think this is a good idea - we may end up "leaking" connections for other clients - or messing things up for clients which have randomized host lists.. (though for this, I guess we can have another fix - to make array lists containing the same hosts be made as the same key (for hashing purposes)) for persistent connections.

        A better idea would be to make the persistent connection stuff enforcible by an INI config entry (so the code in the ctor doesn't need to change) - chances are such an option already exists - this would be a fairly sufficient workaround for some of the issues we've been seeing while not breaking code for those people who do not want these so-called persistent connections.

        Show
        mnunberg Mark Nunberg (Inactive) added a comment - I don't think this is a good idea - we may end up "leaking" connections for other clients - or messing things up for clients which have randomized host lists.. (though for this, I guess we can have another fix - to make array lists containing the same hosts be made as the same key (for hashing purposes)) for persistent connections. A better idea would be to make the persistent connection stuff enforcible by an INI config entry (so the code in the ctor doesn't need to change) - chances are such an option already exists - this would be a fairly sufficient workaround for some of the issues we've been seeing while not breaking code for those people who do not want these so-called persistent connections.

          People

          • Assignee:
            trond Trond Norbye
            Reporter:
            trond Trond Norbye
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes