Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-205

couchbase_res->rc not set on view execute failure

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: library
    • Security Level: Public
    • Labels:
      None
    • Environment:
      php-ext-couchbase git master @9a301ada0bf7

      Description

      In views.c in php_couchbase_view_impl(), the couchbase_res->rc result code is last set in case the lcb_timer can't be created. But it is not set in case of any further failures in actually processing the view results.

      I expect it to clear the flag (set it to LCB_SUCCESS) on success, and set it to some meaningful error code in the failure branches:

      https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L357

      https://github.com/couchbase/php-ext-couchbase/blob/cf70968ed3f0c781e75e4cc43de6c561019b459d/views.c#L369

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        trond Trond Norbye added a comment -

        the rc value is set in the callback for other errors.

        Show
        trond Trond Norbye added a comment - the rc value is set in the callback for other errors.

          People

          • Assignee:
            ingenthr Matt Ingenthron
            Reporter:
            TimSmith Tim Smith (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes