Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-487

Logic for adhoc vs prepared queries is inverted

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.3.0, 2.3.1, 2.3.2
    • 2.3.3
    • library
    • None

    Description

      The logic for adhoc vs prepared queries is inverted, so if $query->adhoc is set to true (or left as default), then the query is prepared, and if $query->adhoc is set to false then the query is not prepared. This is the opposite to what is expected to happen.

      Patch incoming.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Sergey Avseyev PR: https://github.com/couchbase/php-couchbase/pull/18

          If you'd rather I pushed it through review.couhbase.org instead let me know.

          malarky Chris Malarky added a comment - Sergey Avseyev PR: https://github.com/couchbase/php-couchbase/pull/18 If you'd rather I pushed it through review.couhbase.org instead let me know.

          Thank you, I've pulled your change into gerrit

          avsej Sergey Avseyev added a comment - Thank you, I've pulled your change into gerrit

          Sergey Avseyev Can we have this added as a known issue in the Release Notes?

          malarky Chris Malarky added a comment - Sergey Avseyev Can we have this added as a known issue in the Release Notes?

          Sure.

          avsej Sergey Avseyev added a comment - Sure.

          Thanks

          malarky Chris Malarky added a comment - Thanks

          People

            malarky Chris Malarky
            malarky Chris Malarky
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty