Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-487

Logic for adhoc vs prepared queries is inverted

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0, 2.3.1, 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: library
    • Labels:
      None

      Description

      The logic for adhoc vs prepared queries is inverted, so if $query->adhoc is set to true (or left as default), then the query is prepared, and if $query->adhoc is set to false then the query is not prepared. This is the opposite to what is expected to happen.

      Patch incoming.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          malarky Chris Malarky created issue -
          Hide
          malarky Chris Malarky added a comment -

          Sergey Avseyev PR: https://github.com/couchbase/php-couchbase/pull/18

          If you'd rather I pushed it through review.couhbase.org instead let me know.

          Show
          malarky Chris Malarky added a comment - Sergey Avseyev PR: https://github.com/couchbase/php-couchbase/pull/18 If you'd rather I pushed it through review.couhbase.org instead let me know.
          avsej Sergey Avseyev made changes -
          Field Original Value New Value
          Status New [ 10003 ] Open [ 1 ]
          avsej Sergey Avseyev made changes -
          Fix Version/s 2.3.3 [ 14509 ]
          Hide
          avsej Sergey Avseyev added a comment -

          Thank you, I've pulled your change into gerrit

          Show
          avsej Sergey Avseyev added a comment - Thank you, I've pulled your change into gerrit
          avsej Sergey Avseyev made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          malarky Chris Malarky made changes -
          Link This issue blocks CBSE-3707 [ CBSE-3707 ]
          Hide
          malarky Chris Malarky added a comment -

          Sergey Avseyev Can we have this added as a known issue in the Release Notes?

          Show
          malarky Chris Malarky added a comment - Sergey Avseyev Can we have this added as a known issue in the Release Notes?
          Hide
          avsej Sergey Avseyev added a comment -

          Sure.

          Show
          avsej Sergey Avseyev added a comment - Sure.
          Hide
          malarky Chris Malarky added a comment -

          Thanks

          Show
          malarky Chris Malarky added a comment - Thanks

            People

            • Assignee:
              malarky Chris Malarky
              Reporter:
              malarky Chris Malarky
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.