Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-58

Couchbase.so - constructing Couchbase() doesn't throw an exception on connection error

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.0
    • Fix Version/s: None
    • Component/s: library
    • Security Level: Public
    • Labels:

      Description

      When constructing Couchbase() and it fails to connect, no exception is thrown, which results in that condition being impossible to be caught... It would be really helpful if the constructor could throw an exception...

      Steps to reproduce:

      1. shut down Couchbase server or provide invalid host
      2. wrap couchbase constructor in try..catch block, e.g.
      try

      { $cb = new Couchbase($host, $couchbase['username'], $couchbase['password'], $couchbase['bucket']); }

      catch(Exception $e)

      { // couldn't connect to couchbase error_log("cb error"); }

      3. notice how no exception is caught when couchbase fails to connect...

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          mnunberg Mark Nunberg added a comment -

          Connection error handling has been extensively dealt with and resolved in later issues..

          In summary, while no exception is thrown, it is possible to check if the connection succeeded or not.

          Show
          mnunberg Mark Nunberg added a comment - Connection error handling has been extensively dealt with and resolved in later issues.. In summary, while no exception is thrown, it is possible to check if the connection succeeded or not.
          Hide
          ingenthr Matt Ingenthron added a comment -

          Mark: Please determine if this issue is still valid and help me triage it into the appropriate release. I've assigned it to you for triage, not necessarily to fix it.

          Show
          ingenthr Matt Ingenthron added a comment - Mark: Please determine if this issue is still valid and help me triage it into the appropriate release. I've assigned it to you for triage, not necessarily to fix it.

            People

            • Assignee:
              mnunberg Mark Nunberg
              Reporter:
              mssteuer Michael Steuer
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes