Uploaded image for project: 'Couchbase PHP client library'
  1. Couchbase PHP client library
  2. PCBC-73

get() method signature less optimal than it could be

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.1.0
    • Component/s: library
    • Security Level: Public
    • Labels:
      None

      Description

      It'd be great to move the $cas_token parameter to the second place as $cas_token is more likely to be used with get() than $callback. At least it would seem that way given the existence of two callback-focused/requiring functions: getDelayed and getDelayedByKey.

      Due to this already being in use, it may need some type detection so that the two parameters technically become interchangeable within the signature, but we throw a deprecation warning (starting with 1.1) that states that $cas_token should come second going forward.

      Additionally in 1.0.3, the callback for get() does not seem to be called--erroneous variable name output doesn't throw any errors, and basic echo's don't ever "surface" into the buffer.

      Thanks.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        ingenthr Matt Ingenthron added a comment -

        Trond: assigning to you to determine if still an issue and triage.

        Show
        ingenthr Matt Ingenthron added a comment - Trond: assigning to you to determine if still an issue and triage.

          People

          • Assignee:
            trond Trond Norbye
            Reporter:
            BigBlueHat Benjamin Young
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes