Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: library
    • Security Level: Public
    • Labels:
      None

      Description

      The vBucket Aware client only accepts 1 server. So if that server is down at the time of initial connection. The client will never connect. This results in users needing to write special code to handle this or put a Load Balance in between. Which a balancer would reduce performance. Client should ideally take a collection of servers like Standard Memcached Clients do, and auto connect to a different one if it fails connection.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        nerdynick nerdynick created issue -
        Hide
        nerdynick nerdynick added a comment - - edited

        I've created a patch to resolve this. The patch also provides other fixes/improvements to passing in server configs. You can now pass username/password via URL Strings. URL String parsing now uses urlparse with support for Python 3.0 version of urlparse. You can also pass a preconfigured dict in the internal format.

        https://github.com/nerdynick/couchbase-python-client/commit/dc7fe00a49f8d012d28286811ee8ac3ddbfd34e9
        https://github.com/nerdynick/couchbase-python-client/commit/6fad7ca01c6dd0cd6895aed8a81c70c301bbaa5d

        There are also a 2 other commits before that remove the disabling of logging. As this effects application logging not just Couchbase logging. It also contains a minor patch that turns the Dispatcher into an inherited Thread vs using a function. Allows everything to be a little more contained.

        Show
        nerdynick nerdynick added a comment - - edited I've created a patch to resolve this. The patch also provides other fixes/improvements to passing in server configs. You can now pass username/password via URL Strings. URL String parsing now uses urlparse with support for Python 3.0 version of urlparse. You can also pass a preconfigured dict in the internal format. https://github.com/nerdynick/couchbase-python-client/commit/dc7fe00a49f8d012d28286811ee8ac3ddbfd34e9 https://github.com/nerdynick/couchbase-python-client/commit/6fad7ca01c6dd0cd6895aed8a81c70c301bbaa5d There are also a 2 other commits before that remove the disabling of logging. As this effects application logging not just Couchbase logging. It also contains a minor patch that turns the Dispatcher into an inherited Thread vs using a function. Allows everything to be a little more contained.
        Hide
        BigBlueHat Benjamin Young added a comment -

        @nerdynick, thanks for the work you've put into fixing this issue! I'd love to get this patch into the Python SDK.

        Would you mind shipping these in through our Gerrit Code Review system? Information on getting that setup is here:
        http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes

        Once you've got that setup, it should be fairly straight forward to continue contributing--which we'd love!

        Thanks much.

        Show
        BigBlueHat Benjamin Young added a comment - @nerdynick, thanks for the work you've put into fixing this issue! I'd love to get this patch into the Python SDK. Would you mind shipping these in through our Gerrit Code Review system? Information on getting that setup is here: http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes Once you've got that setup, it should be fairly straight forward to continue contributing--which we'd love! Thanks much.
        BigBlueHat Benjamin Young made changes -
        Field Original Value New Value
        Fix Version/s 0.8.0 [ 10354 ]
        Hide
        ingenthr Matt Ingenthron added a comment -

        @benjamin, can you followup with nick and see if he can just do the CLA clickthrough, and then we can integrate it ourselves?

        Show
        ingenthr Matt Ingenthron added a comment - @benjamin, can you followup with nick and see if he can just do the CLA clickthrough, and then we can integrate it ourselves?
        ingenthr Matt Ingenthron made changes -
        Fix Version/s 0.9.0 [ 10373 ]
        Fix Version/s 0.8.0 [ 10354 ]
        ingenthr Matt Ingenthron made changes -
        Assignee Matt Ingenthron [ ingenthr ] Mark Nunberg [ mnunberg ]
        mnunberg Mark Nunberg made changes -
        Fix Version/s 0.10.0 [ 10607 ]
        Fix Version/s 0.9.0 [ 10373 ]
        Hide
        mnunberg Mark Nunberg added a comment -

        Duplicate of PYCBC-97; fixed

        Show
        mnunberg Mark Nunberg added a comment - Duplicate of PYCBC-97 ; fixed
        mnunberg Mark Nunberg made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Duplicate [ 3 ]
        mnunberg Mark Nunberg made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        brett19 Brett Lawson made changes -
        Workflow jira [ 16256 ] Couchbase SDK Workflow [ 44557 ]

          People

          • Assignee:
            mnunberg Mark Nunberg
            Reporter:
            nerdynick nerdynick
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes