Major Description
The current Python client implementation has some extra stuff that I think maybe leftover from earlier experiments and should be removed so we don't cause confusion about conformity.
Found when reviewing the sdk-rfc:
cb.lookup_in(docid, SD.get_fulldoc(), SD.get('my.xattr', xattr=True)) |
cb.mutate_in(docid, SD.upsert_fulldoc(docid), SD.upsert('my.xattr', xattr=True)) |
Looking around, I don't see any indication that the get_fulldoc or upsert_fulldoc exist elsewhere.
Will confirm and then remove if needed.
Attachments
Activity
Hey Matt,
According to the RFC, if your SDK implements fulldoc operations (for use in concert with xattrs), then you would implement it by using a blank path as opposed to an independent method.
Cheers, Brett
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Brett Lawson [ brett19 ] | Matt Ingenthron [ ingenthr ] |
| Status | New [ 10003 ] | Open [ 1 ] |
| Assignee | Matt Ingenthron [ ingenthr ] | Ellis Breen [ ellis.breen ] |
Not sure where those code snippets are from, but the only references I can find to upsert/get_fulldoc are in priv_constants.py and subdoc_t.py . It is mentioned here:
"PYCBC-404, PYCBC-402: GET_COUNT and other subdoc additions
This adds the `get_count()` subdocument operation. It also adds support
for the `get_fulldoc()` and `upsert_fulldoc()` operations which can be
used to retrieve and modify the entire document, respectively."
According to the sdk-rfc mentioned in PCYCB-404 ( https://docs.google.com/document/d/1z3pJCPg77PZ8U8rFAyABuEhHSl68j1n42zP2RyflWZs/edit#heading=h.7ha864pzwf8m ):
"In the SDKs the proposed way to expose this is by allowing an empty path to the get() and upsert() sub-functions of LookupInBuilder. MutateInBuilder." - as Brett Lawson reiterated.
Seems pretty safe to remove as far as I can tell - will try tomorrow.
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
Brett Lawson: as sdk-rfc owner, can you confirm? I didn't see this in go or the sdk-rfc. You can assign it back to me or to Michael Goldsmith after confirming.