Uploaded image for project: 'Spymemcached Java Client'
  1. Spymemcached Java Client
  2. SPY-78

TAP operation messages may never be removed from the TAP stream

    Details

    • Type: Bug
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: .next
    • Component/s: None
    • Security Level: Public
    • Labels:
      None

      Description

      When looking through the TapStream abstraction added, I see it creates an ArrayList of operations (being sent to the server it seems?) but never cleans them up. This would be a reference leak with a long running TAP.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        mikew Mike Wiederhold added a comment -

        Those are your handles to the tap stream. Those operations need to stay around until the tap stream is finished since their completed() function is only called once the tap stream is finished.

        Show
        mikew Mike Wiederhold added a comment - Those are your handles to the tap stream. Those operations need to stay around until the tap stream is finished since their completed() function is only called once the tap stream is finished.
        Hide
        ingenthr Matt Ingenthron added a comment -

        Assigning to Mike just to ask for verification of behavior here. If this is an actual issue, Rags or I can fix it, but I don't fully understand the TapStream abstraction.

        Show
        ingenthr Matt Ingenthron added a comment - Assigning to Mike just to ask for verification of behavior here. If this is an actual issue, Rags or I can fix it, but I don't fully understand the TapStream abstraction.

          People

          • Assignee:
            ingenthr Matt Ingenthron
            Reporter:
            ingenthr Matt Ingenthron
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Gerrit Reviews

              There are no open Gerrit changes