CHANGELOG for ep-engine * Commit: b4c858eee860a6a7e2e17a071965fc1f9fd81cf1 (in build: 2135) Author: Manu Dhundi MB-14988: Add helper funcs write_items() and write_items_upto_mem_perc() In ep_testsuite umpteen times we write a bunch of items or items upto a memory usage on server. Having helper functions do this will avoid unncessary repetition of code. Change-Id: Ia5b940390f35c828c0c208a79c6af7d5dbdc2bf4 Reviewed-on: http://review.couchbase.org/62679 Tested-by: buildbot Reviewed-by: Chiyoung Seo * Commit: f911af696f23ee09955bd9f74e0b766e3956887c (in build: 2136) Author: Manu Dhundi MB-19029: Wait for consumer task to run before checking backoffs Backfoff stat is updated only after consumer processor task runs. Hence it is better to wait for the stat than to query it for a particular value. Change-Id: I8c88f76d5ac6d6623ae5b3681438a3dd6c05ea65 Reviewed-on: http://review.couchbase.org/62808 Reviewed-by: Dave Rigby Reviewed-by: Chiyoung Seo Tested-by: Manu Dhundi CHANGELOG for forestdb * Commit: 73449b7726f2b47122170fe3252ee3f0495232d1 (in build: 2134) Author: Chiyoung Seo MB-19023 Don't release a filemgr's lock twice upon compaction failure When the compaction fails due to the commit failure on the old file, then the new file_mgr's lock is released before calling _fdb_cleanup_compact_err(). Therefore, we shouldn't release it again in _fdb_cleanup_compact_err(). Change-Id: If31226aaa8d2919700e3e12ba3d644d818d0513c Reviewed-on: http://review.couchbase.org/62828 Reviewed-by: Jung-Sang Ahn Tested-by: Chiyoung Seo * Commit: 1c75bd93b8d190b935be523640f0837b4d8e7af0 (in build: 2140) Author: abhinavdangeti Address compiler warning seen in filemgr.cc /home/abhinav/couchbase/forestdb/src/filemgr.cc:3560:27: warning: ‘addr’ may be used uninitialized in this function [-Wmaybe-uninitialized] block->addr = addr; ^ Change-Id: If78928413476e3bde7d5838b0779e564a3535b5c Reviewed-on: http://review.couchbase.org/62852 Reviewed-by: Chiyoung Seo Tested-by: Chiyoung Seo * Commit: 92a56e757093ec4520e5f254a7f9c2f6a6b1b24a (in build: 2141) Author: abhinavdangeti Address test heap-use-after-free issue 11:25:22 WARNING: ThreadSanitizer: heap-use-after-free (pid=115558) 11:25:22 Read of size 8 at 0x7d040000f308 by main thread: 11:25:22 #0 _cmp_double(void*, unsigned long, void*, unsigned long) /home/couchbase/.ccache/tmp/fdb_functi.tmp.140592e37b0d.95346.ii (fdb_functional_test+0x0000004d4dcc) 11:25:22 #1 __wal_cmp_bykey(wal_item_header*, wal_item_header*, void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:80 (fdb_functional_test+0x000000548483) 11:25:22 #2 _snap_cmp_bykey(avl_node*, avl_node*, void*) /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:116 (fdb_functional_test+0x000000547ffc) 11:25:22 #3 avl_search_greater /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/avltree.cc:351 (fdb_functional_test+0x0000004e2f96) 11:25:22 #4 wal_itr_search_greater /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/wal.cc:2179 (fdb_functional_test+0x000000542d42) 11:25:22 #5 fdb_iterator_init (fdb_functional_test+0x00000052b345) 11:25:22 #6 custom_compare_primitive_test() crtstuff.c (fdb_functional_test+0x0000004d4692) 11:25:22 #7 main crtstuff.c (fdb_functional_test+0x0000004e258a) 11:25:22 11:25:22 Previous write of size 8 at 0x7d040000f308 by main thread (mutexes: write M672581587812037744): 11:25:22 #0 free (fdb_functional_test+0x00000046144b) 11:25:22 #1 free_docio_object /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/docio.cc:1067 (fdb_functional_test+0x0000004fb29a) 11:25:22 #2 fdb_kvs_header_read /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/kv_instance.cc:1134 (fdb_functional_test+0x000000532fba) 11:25:22 #3 _fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:1980 (fdb_functional_test+0x00000050b393) 11:25:22 #4 fdb_open /home/couchbase/jenkins/workspace/forestdb-threadsanitizer-master/forestdb/src/forestdb.cc:807 (fdb_functional_test+0x0000005096ea) 11:25:22 #5 seq_tree_exception_test() crtstuff.c (fdb_functional_test+0x0000004cde92) 11:25:22 #6 main crtstuff.c (fdb_functional_test+0x0000004e257b) Change-Id: I9191bc57e00fefadb0f31fee7cc48c3ad04cf43b Reviewed-on: http://review.couchbase.org/62875 Reviewed-by: Chiyoung Seo Tested-by: Chiyoung Seo * Commit: 3f8ea205f9267b2159460aeb5d482defff015275 (in build: 2141) Author: abhinavdangeti Addressing various detected static analyzer issues Change-Id: I6a9af023e9ba811da7d8069a0491c41378bbc259 Reviewed-on: http://review.couchbase.org/62864 Tested-by: buildbot Reviewed-by: Chiyoung Seo Reviewed-by: Jung-Sang Ahn * Commit: ad0a1e2ff5e144d69c8ddbea453811d9a1f7e01c (in build: 2143) Author: Jung-Sang Ahn Check bmp_size before accessing bitmap - Out-of-bound access to bitmap may occur. Change-Id: Icc465e8456435d58f058e234c15e8e82c68e8416 Reviewed-on: http://review.couchbase.org/62893 Tested-by: buildbot Reviewed-by: Chiyoung Seo CHANGELOG for indexing * Commit: 6efc2f6db5c6c8a695fc3f32b05890879a1434c0 (in build: 2134) Author: Sarath Lakshman MB-19020 memdb: Fix pointers per node stats aggregation Change-Id: I433f19270746aa70d1da4a334dd30ed6c79e16d9 * Commit: 10420ee3de6e692c9ca4ed7a87a0dbe840fbfb98 (in build: 2134) Author: deepkaran MB-19062 Do not delete old fdb file after compaction Forestdb has in-built mechanism for deleting the old file after compaction. Change-Id: I74b60a9c20365e366d85b3c2a4a18dda77b277fa * Commit: fbda47d51399da7007455c83a6e8294d122e3425 (in build: 2134) Author: prataprc MB-19005: projector/dcp fix memory leak. when dcp socker receiver is blocked down stream and projector feed is shutdown there is a chance that doReceive() routine might get orphaned the orphaned routines keep references to mutated documents preventing the GC collection. Change-Id: Ia5f2351539a8ef75871932a6141d02ff40641014 * Commit: 9ee055862866d91534a8231041c45bb5296a64f2 (in build: 2134) Author: Sriram Melkote Merge branch 'unstable' http://ci2i.northscale.in/gsi-moi-14.04.2016-14.17.pass.html http://ci2i.northscale.in/gsi-fdb-14.04.2016-16.33.pass.html * Commit: 27997fd1a162eb5b6d47e3a9212cb9f239ca4193 (in build: 2134) Author: johliang00 MB-19118: generate in-memory snapshot for initial index build for MOI Change-Id: Id447204f112030e4641ad22c6555b2c5e99da9b3 * Commit: be0580bacff46d01f4afb22f5e02c83c042724df (in build: 2134) Author: Sarath Lakshman MB-19141 scanner: Add stats counter for index-not-ready errors This is avoid unnecessary repeated logging which causes mutation ingestion rates. This change improves insertion throughput with background scans from 30k/s to 600k/s Change-Id: I35e771e9289a396d6b106ce59954aaab0e88de6e * Commit: 2116254540e9cf3efa92023ded102567f0c2bdc7 (in build: 2134) Author: Sarath Lakshman MB-19162 memdb: Fix snapshot leak during attempt for disk snapshot Change-Id: I75dd97ab24cfa4bbe98b9d708bf7858ea508076b * Commit: 0cfc1d25c73875ef0576f688f83a5ac04fd7f8d1 (in build: 2134) Author: Sriram Melkote MB-19165: Use fixed length fraction for milliseconds Currently number of digits in millisecond field is variable. Make it fixed 3 digits for ease reading. Change-Id: Iea44a7759ce15e59d56f52853c86ed2b2187a5cd * Commit: cd048b09f4e7078431be5f08391fae0d3b9caf32 (in build: 2134) Author: Sarath Lakshman MB-19107 indexer: Update dcp timing stats only if stats object is populated If an index is not ready or not present, stats object is not populated. Hence a check is added before trying to update dcp stats. Change-Id: I76f5b883f82a87fa2d80623c5cd4340257988ad9 * Commit: 0d11caf47c7d615f9bf2feb44e4cd82e851cd2c0 (in build: 2134) Author: deepkaran MB-18979 Adjust log level in kv_sender Change log level from Fatal->Error. All projector errors are going to be retried. Change-Id: Ic7395b2c30572d49243f9709f882cd15fb365cb8 * Commit: 41af1417249ae7efe12ba57506774f28f3cdfe87 (in build: 2134) Author: Sriram Melkote MB-100: Ignore memcapable.WarmUpMemcachedTest.do_warmup_100k Nobody seems to care about this test failure. Change-Id: Ie2d81626ac303f6639adc6395dedc33b80e9e042 * Commit: f0d8996cf8ccdaf1a8f930ab85431d51f0a7c3b9 (in build: 2134) Author: Sarath Lakshman MB-18203 indexer: Fix error handling during disk usage estimation Change-Id: Ib2a296aa4d110f7d7aa6561dd5f8c7b728fd1027 * Commit: cfe946ca12341ede19853e52fbebe711ebb91deb (in build: 2134) Author: Prathibha MB-19111: Fix stat numItemsFlushed for array index nmut in forestdb slice write and memdb implementation is fixed to actual number of elements that get updated and deleted. Change-Id: I01d47dd4ad697b04568380c8978bd7c0b2cd12fa * Commit: cb0b996856c068e7fc7543406fb091e6a1c464d8 (in build: 2134) Author: Sriram Melkote MB-19172: Remove SIGUSR2 handler We have a facility to dump routines on SIGUSR2 but given problems seen elsewhere with signal handling in go processes, it is best to remove this facility to avoid any unexpected side effects downstream. Change-Id: I02afe320f07475273d5384ba7206f8a2200c2c42 CHANGELOG for query * Commit: 1b3b0d288861c7cbb7ef73a2cdde924286c65099 (in build: 2136) Author: ikandaswamy MB-19009 : Handle histfile (history) path for windows correctly. Also handle resetting value of histfile for all os after \pop. Change-Id: I174012f37613bfd4ef54906bf02be8fc11a98142 Reviewed-on: http://review.couchbase.org/62814 Reviewed-by: Gerald Sangudi Reviewed-by: Keshav Murthy Tested-by: Isha Kandaswamy * Commit: bbf509aac5364c41c8272a7569c448e50d7ed640 (in build: 2136) Author: ikandaswamy MB-19021 : Restoring 8091 to be the default port cbq connects to. Change-Id: If375856dc1775d4cfb172eccf110bee48a0f3ddb Reviewed-on: http://review.couchbase.org/62854 Reviewed-by: Gerald Sangudi Tested-by: Isha Kandaswamy * Commit: 8197255a9089cfea07a41d8fde2447978c9bd426 (in build: 2138) Author: geraldss Fix MB-19195. Fix planner to use indexes for IN and WITHIN predicates when the RHS is not a small static array. Change-Id: Ifabec01e16e95ce88f0d9be9c2d53c95a3f2e0ba Reviewed-on: http://review.couchbase.org/62861 Reviewed-by: Gerald Sangudi Tested-by: Gerald Sangudi * Commit: 70faf77c35d56b99574cae2426cf744d1d4e4f47 (in build: 2140) Author: ikandaswamy MB-19154 : Handle named parameters properly after it is popped or deleted. Change-Id: I91a6844cf34c02c3a411c2abb5f96b45f45c1ac0 Reviewed-on: http://review.couchbase.org/62865 Reviewed-by: Sitaram Vemulapalli Reviewed-by: Gerald Sangudi Tested-by: Isha Kandaswamy * Commit: ea9ee8323beb584eeb6ad15611da663bb0d4a96a (in build: 2141) Author: sitaramv MB-19215 number of elements in IN clause more than 16 convert to range scan instead of FULL_SCAN Change-Id: Ibd62e45be9833e7b7c1f296d86e3009e7e82f5da Reviewed-on: http://review.couchbase.org/62871 Reviewed-by: Gerald Sangudi Tested-by: Sitaram Vemulapalli * Commit: 97069272444d44692790d558d4bb830d3ebceaad (in build: 2146) Author: ikandaswamy MB-19197 Fix last set of issues with histfile for \pop, \unset and display path to histfile depending on -quiet flag Change-Id: I866f977ce8bf05042c93d01959ae2d8d2eac9735 Reviewed-on: http://review.couchbase.org/62885 Reviewed-by: Sitaram Vemulapalli Reviewed-by: Marco Greco Reviewed-by: Gerald Sangudi Tested-by: Isha Kandaswamy