Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-1427

ISGR should not try sending a delta when deltaSrc is a tombstone

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.8.0
    • 3.0
    • SyncGateway
    • Security Level: Public
    • CBG Sprint 82
    • 5

    Description

      It looks like ISGR is trying to send deltas for revisions where the deltaSrc rev was a tombstone. This is not something we can handle correctly, and Sync Gateway rightfully returns an error in response to the attempt - but we shouldn't be sending a delta in the first place.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            ben.brooks Ben Brooks added a comment -
            1. Write test to reproduce issue (using ISGR and delta sync)
            2. Have sendRevAsDelta fall back to full body replication when we know deltaSrcRevID is a tombstone
            ben.brooks Ben Brooks added a comment - Write test to reproduce issue (using ISGR and delta sync) Have sendRevAsDelta fall back to full body replication when we know deltaSrcRevID is a tombstone

            Build sync_gateway-3.0.0-417 contains sync_gateway commit 7ed7d49 with commit message:
            CBG-1427 - Full Body replication is sent when delta source is tombstone (#5241)

            build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-417 contains sync_gateway commit 7ed7d49 with commit message: CBG-1427 - Full Body replication is sent when delta source is tombstone (#5241)

            Build sync_gateway-3.0.0-418 contains sync_gateway commit 0757c36 with commit message:
            CBG-1427 Race condition fix (#5251)

            build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-418 contains sync_gateway commit 0757c36 with commit message: CBG-1427 Race condition fix (#5251)

            People

              isaac.lambat Isaac Lambat
              ben.brooks Ben Brooks
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty