Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

[3.0.1 Backport] One shot sub changes request does not decrement NumPullReplActiveOneShot stat when completed

Description

The NumPullReplActiveOneShot stat is not decremented when a one shot sub changes request has finished pulling and sending the sub changes. It will decrement when closing the Blip client provided it has NOT been reused.

Reusing the Blip client causes the decrement code not to run as it is only ran when closing the client. This code is in function (bsc *BlipSyncContext) Close().
Running a one-shot before reusing the blip client for a continuous changes feed will cause the continuous to be replaced meaning that even when the Blip client is closed, the one shot active stats don't get decremented accordingly.

A potential solution to this is to decrement the one shot stat for Blip SubChangesOneShotActive (which is used for the db stat NumPullReplActiveOneShot) when the one shot has sent the results instead of doing it when the Blip client is closed.

Activity

Show:

CB robot March 28, 2022 at 10:52 AM

Build sync_gateway-3.0.1-4 contains sync_gateway commit 36c267c with commit message:
[Backport 3.0.1] : : NumPullReplActiveOneShot decrements on sub changes feed completion (#5486)

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Components

Sprint

Fix versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created March 21, 2022 at 5:54 PM
Updated October 15, 2024 at 3:07 PM
Resolved May 10, 2022 at 5:37 PM
Instabug