[3.0.9 backport] Replicator will not reconnect when max_back_off != 0
Description
When TotalReconnectTimeout is set to 0, reconnect for a replicator is disabled.
We set this value to a non zero value when MaxBackOff is 0 as when we have a zero value for MaxbackOff we want to retry ~MaxReconnectInterval. But when we set the MaxBackOff value we want to try indefinitely to reconnect with the maximumn back of time supplied.
Our reconnect loops are configured to check if the TotalReconnectTimeout is 0 or not and will skip reconnect loops if it has a 0 value. This means as it stands if we set a MaxBackOff value in replicator config the reconnect loop will not start this will not attempt to reconnect.
Gregory Newman-Smith September 19, 2023 at 10:34 AM
Verified that it is not needed on 3.0.9 and was a regression in 3.1. Ran test I had in original PR and it passed without any extra changes to the code.
Adam Fraser September 18, 2023 at 4:58 PM
Verify this isn't needed in 3.0.x.
Fixed
Pinned fields
Click on the next to a field label to start pinning.
When TotalReconnectTimeout is set to 0, reconnect for a replicator is disabled.
We set this value to a non zero value when MaxBackOff is 0 as when we have a zero value for MaxbackOff we want to retry ~MaxReconnectInterval. But when we set the MaxBackOff value we want to try indefinitely to reconnect with the maximumn back of time supplied.
Our reconnect loops are configured to check if the TotalReconnectTimeout is 0 or not and will skip reconnect loops if it has a 0 value. This means as it stands if we set a MaxBackOff value in replicator config the reconnect loop will not start this will not attempt to reconnect.