Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-3723

[3.1.4 backport] TCP_NODELAY does not work for TLS connections

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 3.1.4
    • None
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 145
    • 1

    Description

      The code to turn on NODELAY for TCP connections does not check for any types other than `*net.TCPConn`. TLS connections have a conn which is of a type `*tls.Conn` which wraps a `*net.TCPConn`, resulting in one that is not able to set NODELAY.

      2023-05-16T09:10:42.421-07:00 [WRN] Couldn't turn off NODELAY for &{...}: it's not a TCPConn -- base.turnOffNoDelay() at util.go:1655

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gregory.newmansmith Gregory Newman-Smith
            ben.brooks Ben Brooks
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty