Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-3983

[3.1.9 backport] sgcollect_info: Switch to runtime config endpoint to determine logFilePath

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 3.1.9
    • None
    • SyncGateway
    • Security Level: Public
    • CBG Sprint 152
    • 1

    Description

      sgcollect_info should determine the active log_file_path based on runtime config endpoint, rather than the non-runtime config endpoint. The runtime version would include the defaultLogFilePath fallback value if no custom log file path is set, rather than simply being empty.

      Normally this flag is set to a directory already being scanned by sgcollect_info directly, since we usually define those on a per-platform basis in the service scripts. In the case of a custom --defaultLogFilePath and no log_file_path set, sgcollect info fails to find the log files.

      This is something that 99.9% of customers will not hit, since it's expected that --defaultLogFilePath is controlled by us, and they set log_file_path, but is a gap that we can close up relatively easily.

      Proposed Fix:

      https://github.com/couchbase/sync_gateway/blob/d106b462d66d2fea6891691a2b73a744530546fc/tools/sgcollect_info#L266-L268

      Change config_url to /_config?include_runtime=true 

      This will still work on versions prior to 3.0, since unknown query params will simply be ignored.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gregory.newmansmith Gregory Newman-Smith
            ben.brooks Ben Brooks
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty