Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-633

Clean up duplicate db definitions in blipHandler/blipSyncContext

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 2.8.0
    • None
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 38
    • 3

    Description

      blipHandler defines a db property on its struct, but also embeds blipSyncContext which has its own db property. The majority of references access the db through blipHandler (and so will be using that version), but there are a few places the db on the context is being explicitly references - within Logf, a few stats references, and the DeltaSyncEnabled check.

      This should be cleaned up to use a single db reference, as the outer database reference gets refreshed when the user is reloaded, but the blipSyncContext instance isn't.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            adamf Adam Fraser
            adamf Adam Fraser
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty