Uploaded image for project: 'Couchbase Gateway'
  1. Couchbase Gateway
  2. CBG-864

Improve addJSON-related error handling

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 2.8.0
    • None
    • SyncGateway
    • Security Level: Public
    • None
    • CBG Sprint 51
    • 5

    Description

      In addJSON itself, we should remove the full body logging on an encode error. It doesn't provide any particular benefit, given that the JSON being logged has either already been proven to be valid (it's from the bucket), or is something created by Sync Gateway.

      In addition, several callers of addJSON are ignoring errors. In the event of an error that's caused by client disconnection, it makes sense to detect the error and stop iterating over other results. Right now addJSON is only checking for "write: broken pipe" - it would be a good idea to identify a broader set of 'client disconnect' type errors and handle them in the same way.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jacques.rascagneres Jacques Rascagneres
            adamf Adam Fraser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty