Uploaded image for project: 'Couchbase Lite'
  1. Couchbase Lite
  2. CBL-2212

Exception can leak out of C4

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.8.5
    • 3.0
    • LiteCore
    • Security Level: Public
    • None
    • 1

    Description

      A general rule is that exception do not get out of c4 API, such as c4log_xyz. However, in error::_throw

      void error::_throw(unsigned skipFrames) {

              if (sWarnOnError && !isUnremarkable()) {

                  if (sNotableExceptionHook)

                      sNotableExceptionHook();

              ......

      The exception hook may go out of C4.

       

      I encountered this problem by this innocent call of c4

      if (!c4log_writeToBinaryFile(

      {kC4LogVerbose, slice(path), 16*1024, 1, *false*}

      ,

                                               &error)) 

      Supposedly, exception thrown from inside the c4 code should be caught and be reflected in error. However, because of the above, the exception hook calls into c4log_ again. This recursive calls of c4_xyz's caused the app hang because of the plain mutex, as opposed to recursive_mutex.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            jianmin.zhao Jianmin Zhao added a comment -

            dealt with by CBL-2077

            jianmin.zhao Jianmin Zhao added a comment - dealt with by CBL-2077

            People

              The Lite The Lite
              jianmin.zhao Jianmin Zhao
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty