Uploaded image for project: 'Couchbase Lite'
  1. Couchbase Lite
  2. CBL-45

LiteCore time out issues stray busy callback

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.6.0
    • 2.6.0
    • LiteCore
    • Security Level: Public
    • None

    Description

      This is affecting a test on .NET which checks to make sure that a replicator will give up in the face of a nonresponsive endpoint (i.e. with no server running).  It is failing because its retry count is setup to go back to 0 when the replicator goes back to busy.  It is falsely reporting busy often after the 2nd timeout but it is somewhat unclear why.  

      The reason it is going to busy is because of a workaround introduced previously to "finish processing messages after a disconnect".  So there is a flip to busy temporarily before the next "stop" as the replicator drains its mailbox.  For example while the event is running the following could be in the replicator mailbox:

      onClose (replicator)
      childChangedStatus (worker)
      childChangedStatus (worker)

      Because there are things in here the replicator calls back with busy and mistakenly resets the retry count.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          jimb Jim Borden added a comment -

          In the meantime on the platform side this can be worked around by ignoring the retry count reset if a busy status comes in with an error.

          jimb Jim Borden added a comment - In the meantime on the platform side this can be worked around by ignoring the retry count reset if a busy status comes in with an error.
          jens Jens Alfke added a comment - PR:  https://github.com/couchbase/couchbase-lite-core/pull/799

          Build couchbase-lite-core-2.6.0-2176 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-core-2.6.0-2176 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          Build couchbase-lite-cblite-2.6.0-96 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-cblite-2.6.0-96 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          Build couchbase-lite-android-2.6.0-125 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-android-2.6.0-125 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          Build couchbase-lite-log-2.6.0-127 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-log-2.6.0-127 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          Build couchbase-lite-net-2.6.0-109 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-net-2.6.0-109 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          Build couchbase-lite-ios-2.6.0-132 contains couchbase-lite-core commit 8801641 with commit message:
          Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          build-team Couchbase Build Team added a comment - Build couchbase-lite-ios-2.6.0-132 contains couchbase-lite-core commit 8801641 with commit message: Replicator shouldn't go to Busy on disconnect if it never connected (#799)

          People

            jens Jens Alfke
            jimb Jim Borden
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty