Uploaded image for project: 'Couchbase Lite'
  1. Couchbase Lite
  2. CBL-994

deprecated resetCheckPoint() doesn't throw exception when replicator is active

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Test Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: Java-Android
    • Security Level: Public
    • Labels:

      Description

      Mandatory:

      • CBL version: 2.8.0-178 / SG Version: 2.7.0-166
      • SG config:

         {
            "interface":":4984",
            "adminInterface": "0.0.0.0:4985",
            "maxIncomingConnections": 0,
            "maxFileDescriptors": 90000,
            "compressResponses": false,
            "logging": {"debug": {"enabled": true} },
            "SSLCert": "sg_cert.pem",
            "SSLKey": "sg_privkey.pem",
            "databases":{
                "db":{
                    "allow_conflicts": false,
                    "num_index_replicas": 0,
                    "username": "travel-sample",
                    "password": "password",
                    "delta_sync": { "enabled": true},
                    "server":"http://192.168.33.10:8091",
                    "bucket":"travel-sample"
                }
            }
        }

      • Steps to Reproduce:
      1. create cbl db docs
      2. start replicator, wait replicator finishes replication turns becomes idle
      3. call resetCheckPoint() API
      • Actual Result:

      no exception, checkpoint gets reset

      • Expected Result:

      according to the design spec, "#3 If the resetCheckpoint() is called while the replicator is not stopped, an exception will be thrown." this deprecated API resetCheckPoint shoudl throw an exception because replicator is still active

      • Logs : in attachments
      • Github link for the code:

      https://github.com/couchbaselabs/mobile-testkit/blob/master/testsuites/CBLTester/CBL_Functional_tests/TestSetup_FunctionalTests/test_replication.py#L2952

      • Jenkins job failure link:

      http://uberjenkins.sc.couchbase.com:8080/job/CBLITE_Android-Listener-TestServer-Functional-tests/1983/testReport/testsuites.CBLTester.CBL_Functional_tests.TestSetup_FunctionalTests/test_replication/test_resetCheckpointFailure/

      • Pytest Command

      pytest --timeout 1800 --liteserv-version=2.8.0 --liteserv-host=192.168.33.108 --liteserv-port=8080 --no-conflicts --enable-file-logging --delta-sync --sg-ssl --sync-gateway-version=2.7.0-166 --mode=cc --server-version=7.0.0-2083 --liteserv-platform=android --create-db-per-test=cbl-test testsuites/CBLTester/CBL_Functional_tests -s -rsx --use-local-testserver -k test_resetCheckpointFailure

      • What is the last build this test passed: 2.8.0-158

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-lite-java-2.8.0-168 contains couchbase-lite-java-common commit 92bb44c with commit message:
          CBL-994: Make sure to throw an exception on a call to resetCheckpoint unless the replicator is STOPPED

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-lite-java-2.8.0-168 contains couchbase-lite-java-common commit 92bb44c with commit message: CBL-994 : Make sure to throw an exception on a call to resetCheckpoint unless the replicator is STOPPED
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-lite-java-2.8.0-168 contains couchbase-lite-java-ee-root commit b0c6555 with commit message:
          CBL-994: Make sure to throw an exception on a call to resetCheckpoint unless the replicator is STOPPED

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-lite-java-2.8.0-168 contains couchbase-lite-java-ee-root commit b0c6555 with commit message: CBL-994 : Make sure to throw an exception on a call to resetCheckpoint unless the replicator is STOPPED
          Hide
          blake.meike Blake Meike added a comment -

          FIxed in couchbase-lite-java-ee-root: b0c65550f0613bafc57d3ce

          Show
          blake.meike Blake Meike added a comment - FIxed in couchbase-lite-java-ee-root: b0c65550f0613bafc57d3ce
          Hide
          eunice.huang Eunice Huang added a comment -

          verified with build 191

          Show
          eunice.huang Eunice Huang added a comment - verified with build 191
          Hide
          eunice.huang Eunice Huang added a comment -

          2.8.0-191 has been verified and passed

          Show
          eunice.huang Eunice Huang added a comment - 2.8.0-191 has been verified and passed

            People

            Assignee:
            blake.meike Blake Meike
            Reporter:
            eunice.huang Eunice Huang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty