Uploaded image for project: 'Couchbase C client library libcouchbase'
  1. Couchbase C client library libcouchbase
  2. CCBC-1410

Need 'bool invalidate' flag in dynamic auth API to help user process invalidate cred cache on auth failures

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 3.1.3
    • 3.1.4
    • library
    • 1

    Description

      Please refer to lengthy discussions on MB-41596. Since lcb 3.x dropped the caching of cbauth creds (which is present in 2.x) and eventing started maintaining the cache, a hint/flag is required in dynamic auth API to indicate to eventing (or any process that integrates lcb) to invalidate any cached creds on auth failures within lcb. Implementors of the API may or may not use the flag depending on whether they are caching creds or not.

      It will be very useful for eventing to avoid any regressions between 6.6.x & 7.x and remain functionally equivalent till an ideal solution which involves cbauth notifying listeners on creds change in available.

      In addition GetUsername() & GetPassword() APIs can both be collapsed into a single GetUserNameAndPassword(void cookie, const char *host, const char *port, const char *bucket, *bool invalidate) API.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            I plan to submit patch for review by tomorrow (Friday 28 may). And hopefully the change itself will be eventually standardized for all SDKs.

            avsej Sergey Avseyev added a comment - I plan to submit patch for review by tomorrow (Friday 28 may). And hopefully the change itself will be eventually standardized for all SDKs.

            Great to know. Thanks a lot Sergey Avseyev!

            jeelan.poola Jeelan Poola added a comment - Great to know. Thanks a lot Sergey Avseyev !

            I've uploaded patch: http://review.couchbase.org/c/libcouchbase/+/154650. Jeelan Poola, please review and confirm that it is enough to implement cache for credentials on eventing side.

            avsej Sergey Avseyev added a comment - I've uploaded patch: http://review.couchbase.org/c/libcouchbase/+/154650 . Jeelan Poola , please review and confirm that it is enough to implement cache for credentials on eventing side.

            Build couchbase-server-7.0.0-5273 contains libcouchbase commit 8781fc9 with commit message:
            CCBC-1410: refactor dynamic authenticator

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-5273 contains libcouchbase commit 8781fc9 with commit message: CCBC-1410 : refactor dynamic authenticator

            Build couchbase-server-7.0.1-5827 contains libcouchbase commit 8781fc9 with commit message:
            CCBC-1410: refactor dynamic authenticator

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.1-5827 contains libcouchbase commit 8781fc9 with commit message: CCBC-1410 : refactor dynamic authenticator

            Build couchbase-server-7.1.0-1007 contains libcouchbase commit 8781fc9 with commit message:
            CCBC-1410: refactor dynamic authenticator

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1007 contains libcouchbase commit 8781fc9 with commit message: CCBC-1410 : refactor dynamic authenticator

            Build couchbase-server-7.1.0-1450 contains libcouchbase commit 94bcd1f with commit message:
            CCBC-1410: refactor dynamic authenticator

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1450 contains libcouchbase commit 94bcd1f with commit message: CCBC-1410 : refactor dynamic authenticator

            People

              jeelan.poola Jeelan Poola
              jeelan.poola Jeelan Poola
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty