Uploaded image for project: 'C++ Couchbase Client'
  1. C++ Couchbase Client
  2. CXXCBC-40

Operation flags are not consistent

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • 1.0.0
    • None
    • None
    • 1

    Description

      In some cases we use flags to signal behaviour, and in other cases we use explicit fields to signal behaviour. For instance in subdoc, the document-level flags are as explicit fields (mutatein_operation::access_deleted), but the spec-level flags are bitwise flags (mutatein_operation::entry::flags::xattr).

      Additionally, it's a bit strange that the subdoc_opcode is a shared structure between lookupin and mutatein operations, but the flags for those specs is not shared.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            avsej Sergey Avseyev
            brett19 Brett Lawson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes