Uploaded image for project: 'Couchbase Go SDK'
  1. Couchbase Go SDK
  2. GOCBC-740

expiry should be a time.Duration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta
    • Fix Version/s: 2.0.0
    • Component/s: library
    • Labels:
      None
    • Story Points:
      1

      Description

      Based on discussion i.e. lockTime is a duration, and I think expiry throughout the SDK should also use it.

      This affects APIs like

      func (c *Collection) GetAndTouch(id string, expiry uint32, opts *GetAndTouchOptions) (docOut *GetResult, errOut error)
      

      but also replace options, GetResult etc .. so if it is changed the whole code needs to be audited. (not filing another ticket for simplicity)

        Attachments

        For Gerrit Dashboard: GOCBC-740
        # Subject Branch Project Status CR V

          Activity

          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.0.0-3115 contains gocb commit 9ba4317 with commit message:
          GOCBC-740: Updated all expiry's to use time.Duration.

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-3115 contains gocb commit 9ba4317 with commit message: GOCBC-740 : Updated all expiry's to use time.Duration.
          Hide
          build-team Couchbase Build Team added a comment -

          Build sync_gateway-3.0.0-52 contains gocb commit 9ba4317 with commit message:
          GOCBC-740: Updated all expiry's to use time.Duration.

          Show
          build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-52 contains gocb commit 9ba4317 with commit message: GOCBC-740 : Updated all expiry's to use time.Duration.

            People

            Assignee:
            brett19 Brett Lawson
            Reporter:
            daschl Michael Nitschinger
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty