Uploaded image for project: 'Couchbase Java Client'
  1. Couchbase Java Client
  2. JCBC-1923

Warn when ignoring connection string parameters or scheme

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.3.0
    • None
    • None
    • 1
    • SDK12: 4.0 p1 + Quality

    Description

      Log a warning if we ignore connection string scheme or parameters because a shared ClusterEnvironment is used.

      Attachments

        For Gerrit Dashboard: JCBC-1923
        # Subject Branch Project Status CR V

        Activity

          michael.reiche Michael Reiche added a comment - - edited

          Why does the tlsEnabled property exist? Isn't the existence of a certificate path sufficient for determining whether or not tls should be used? The separate tlsEnabled property implies there is a use-case for specifying a certificate path, but not using tls.

          michael.reiche Michael Reiche added a comment - - edited Why does the tlsEnabled property exist? Isn't the existence of a certificate path sufficient for determining whether or not tls should be used? The separate tlsEnabled property implies there is a use-case for specifying a certificate path, but not using tls.
          david.nault David Nault added a comment -

          Michael Reiche My guess is `tlsEnabled` exists because shared environments can't be configured using a connection string, so some other way was required.

          I see an argument for `tlsEnabled` being coerced to true if a trust source is specified (why specify a trust source if you're not using TLS?) or at least logging a warning.

          In the short term, the separate `tlsEnabled` flag is useful because the Capella CA certificate is bundled with the SDK, and it lets people use TLS without explicitly specifying a trust source.

          There are certainly things we could do to improve the ergonomics in this area... let's track them separately. JCBC-1928 is a great start.

          david.nault David Nault added a comment - Michael Reiche My guess is `tlsEnabled` exists because shared environments can't be configured using a connection string, so some other way was required. I see an argument for `tlsEnabled` being coerced to true if a trust source is specified (why specify a trust source if you're not using TLS?) or at least logging a warning. In the short term, the separate `tlsEnabled` flag is useful because the Capella CA certificate is bundled with the SDK, and it lets people use TLS without explicitly specifying a trust source. There are certainly things we could do to improve the ergonomics in this area... let's track them separately. JCBC-1928 is a great start.

          People

            david.nault David Nault
            david.nault David Nault
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty