Add support for Micrometer Observation

Description

I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with Tommy Ludwig and Jonatan Ivanov). 

Micrometer Observation is coming as part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).

Since this project already supports Micrometer I was curious if there's interest in adding Micrometer Observation support so that automatically (when on classpath) except for metrics, spans could be created and tracing context propagation could happen too. In other words metrics and tracing of Camel itself could be created + if there are Micrometer Observation compatible projects, then they will join the whole graph (e.g. whole Spring Framework 6 is, Apache Dubbo, Resilience4j etc.).

If there's interest in adding that feature, I can provide a PR.

Environment

None

Gerrit Reviews

None

Release Notes Description

None

Attachments

2
  • 10 Oct 2023, 07:25 AM
  • 08 Oct 2023, 08:33 AM

Activity

Show:

Graham Pople December 21, 2023 at 1:31 PM

Oh, we can live with that - it can be tidied up the next time anyone touches this file.

Marcin Grzejszczak December 21, 2023 at 1:28 PM

Great. Meh, of course now I see that some imports in the tests haven't been automatically deleted (they are unused). What should we do about them?

Graham Pople December 21, 2023 at 1:25 PM

LGTM!  Thank you for the patch.

Marcin Grzejszczak December 21, 2023 at 1:17 PM
Edited

Hopefully I connected all the gerrit dots properly slightly smiling face https://review.couchbase.org/c/couchbase-jvm-clients/+/202961

Graham Pople December 21, 2023 at 12:07 PM

Gerrit would be ideal.  Hopefully the technique is usable from within ObservationRequestTracer.requestSpan(), so it will minimize impact.

 

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Components

Sprint

Fix versions

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created February 8, 2023 at 1:21 PM
Updated February 19, 2024 at 6:06 PM
Resolved January 10, 2024 at 5:27 PM
Instabug