Uploaded image for project: 'Couchbase Java Client'
  1. Couchbase Java Client
  2. JCBC-280

Provision for auth failure in case of calling createBucket in the same txn twice and adding updateBucket functionality

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: Public
    • Labels:
      None

      Description

      There are three ways using which we are creating connection in the java client to the server.

      1) ClusterManager
      2) BucketTool

      Both of these classes internally call the ClusterManager.createBucket for creation of the bucket.

      Now if I am using all the three instances of the above classes in a single function, the bucket information is overridden without any checks. Ideally using any of the connection classes if I have created a SASL bucket with some information like bucket name = 'SaslBucket', bucket password = 'password', I should not be allowed to change the password using instance of another class. There should be auth failure error being returned the second time client tries to connect to the same bucket. Server supports this because there is an Edit Bucket functionality at the server for the same.

      There should be a means of distinction in the request that we want to create the bucket or update.
      In case of bucket creation duplicity should be checked where as in case of update this should be allowed as is.

      Also, the expectation is that, the user might update the bucket information if he requires to change the password or other details, by explicitly calling updateBucket method which is currently not available.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Show
          deeptida Deepti Dawar added a comment - http://review.couchbase.org/#/c/26557/
          Hide
          ingenthr Matt Ingenthron added a comment -

          Deepti: any updates on the underlying issue? Thanks.

          Show
          ingenthr Matt Ingenthron added a comment - Deepti: any updates on the underlying issue? Thanks.
          Hide
          deeptida Deepti Dawar added a comment -

          Hi Matt,

          I have already checked in the code and it is up for review in gerrit.

          Here is the link - http://review.couchbase.org/#/c/26557/

          Regards,
          Deepti

          Show
          deeptida Deepti Dawar added a comment - Hi Matt, I have already checked in the code and it is up for review in gerrit. Here is the link - http://review.couchbase.org/#/c/26557/ Regards, Deepti
          Hide
          ingenthr Matt Ingenthron added a comment -

          Yes, but there's already a review on the patch set indicating there's a problem. Please update the patchset, clarify why what is being observed is expected or get with the reviewer to understand the problem if it's not clear.

          Thanks!

          Show
          ingenthr Matt Ingenthron added a comment - Yes, but there's already a review on the patch set indicating there's a problem. Please update the patchset, clarify why what is being observed is expected or get with the reviewer to understand the problem if it's not clear. Thanks!
          Hide
          deeptida Deepti Dawar added a comment -

          Ah Yes ! Will update in some time.

          Show
          deeptida Deepti Dawar added a comment - Ah Yes ! Will update in some time.

            People

            Assignee:
            deeptida Deepti Dawar
            Reporter:
            deeptida Deepti Dawar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty