Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.4.5
    • docs, library
    • SDK49: HC, Log Reda, CertAuth, SDK4: CAuth 2, Trac 2, Compr., SDK6: Field Enc., Comp, Trace, SDK2: Log Red, Tracing I, SDK8: FE pt2, DP Polishing, SDK10: FE pt2, Beta polishing

    Description

      Goal is to implement log redaction framework following idioms for this platform and then audit all default logging levels to redact to the level required.  See CBD-2147 and links for further information.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            The conversion of the tagged logs will be done by the utility produced in MB-27417.

            ingenthr Matt Ingenthron added a comment - The conversion of the tagged logs will be done by the utility produced in MB-27417 .
            brett19 Brett Lawson added a comment -

            Deferred actual commit to mainline until 2.4.6 due to changes to the libcouchbase API.

            brett19 Brett Lawson added a comment - Deferred actual commit to mainline until 2.4.6 due to changes to the libcouchbase API.

            Log redaction can be enabled using the log_redaction connection string option.  I was originally planning to include a method to turn this on, but I can't find any indication that this was a required bit of the implementation and causes a sort of 'race' between turning it on, and libcouchbase's initial logging.

            brett19 Brett Lawson added a comment - Log redaction can be enabled using the log_redaction connection string option.  I was originally planning to include a method to turn this on, but I can't find any indication that this was a required bit of the implementation and causes a sort of 'race' between turning it on, and libcouchbase's initial logging.

            The challenge I see with it being a connstr option is that someday, somewhere we may log (as in, write to stdout/stderr) directly from node? Or is that not the case until we make major changes? That may need to do the same thing.

            ingenthr Matt Ingenthron added a comment - The challenge I see with it being a connstr option is that someday, somewhere we may log (as in, write to stdout/stderr) directly from node? Or is that not the case until we make major changes? That may need to do the same thing.

            That won't be the case until we make major changes.  Note that the Node.js SDK very much acts as a binding only and doesn't do a whole log of real work.  I can imagine implementing a method at the Cluster level in the future if needed, but even if we implemented logging directly in the binding we could still easily parse the tracing flag from the connection string (we already do this parsing for other reasons).

            brett19 Brett Lawson added a comment - That won't be the case until we make major changes.  Note that the Node.js SDK very much acts as a binding only and doesn't do a whole log of real work.  I can imagine implementing a method at the Cluster level in the future if needed, but even if we implemented logging directly in the binding we could still easily parse the tracing flag from the connection string (we already do this parsing for other reasons).

            People

              brett19 Brett Lawson
              ingenthr Matt Ingenthron
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty