Uploaded image for project: 'Java Couchbase JVM Core'
  1. Java Couchbase JVM Core
  2. JVMCBC-814

Document ID in error contexts should be redacted

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: User Error
    • None
    • 2.0.6, 2.1.0
    • None
    • None
    • 1

    Description

      It's encouraged to dump the error context to log, but it contains this unredacted info.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ascending order - Click to sort in descending order
          daschl Michael Nitschinger added a comment -

          Which one are you referring to?

          we redact the document ID in the base kv context

              if (key != null && key.length > 0) {
          		 
                ctx.put("documentId", redactUser(new String(key, UTF_8)));
          		 
              }

          in which places did we miss it?

          daschl Michael Nitschinger added a comment - Which one are you referring to? we redact the document ID in the base kv context if (key != null && key.length > 0) { ctx.put("documentId", redactUser(new String(key, UTF_8))); } in which places did we miss it?
          graham.pople Graham Pople added a comment -

          I'm going to close this as user error, I bet I didn't have log redaction enabled on the cluster.

          graham.pople Graham Pople added a comment - I'm going to close this as user error, I bet I didn't have log redaction enabled on the cluster.

          People

            graham.pople Graham Pople
            graham.pople Graham Pople
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty