Uploaded image for project: 'Couchbase Kubernetes'
  1. Couchbase Kubernetes
  2. K8S-2421

couchbaseOperator.commandArgs not set correct in Helm Chart 2.1.17

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • helm, kubernetes
    • None
    • 1

    Description

      Background

      When installing the helm chart and setting the "couchbaseOperator.commandArgs.pod-create-timeout" and "couchbaseOperator.commandArgs.zap-level", the "pod-create-timeout" value is ignored. This happens with chart 2.1.17

      Steps to reproduce:

      When installing a chart like so

      ⋊> ~ helm install test --set couchbaseOperator.commandArgs.pod-create-timeout=30m0s --set couchbaseOperator.commandArgs.zap-level=debug couchbase/couchbase-operator --version 2.1.17

      The pood-create-timeout is ignored, as showned in the description:

       
       Host Ports:    0/TCP, 0/TCP
          Command:
            couchbase-operator
          Args:
            --zap-level=debug
      

      Likewise, if we only specify the couchbaseOperator.commandArgs.pod-create-timeout=30m0s then it works

      ⋊> ~ helm install test --set couchbaseOperator.commandArgs.pod-create-timeout=30m0s couchbase/couchbase-operator --version 2.1.17

          Host Ports:    0/TCP, 0/TCP
          Command:
            couchbase-operator
          Args:
            --pod-create-timeout=30m0s
          State:          Running
      
      

      If we use the chart version 2.1.07, we don't hit this error:

      ⋊> ~ helm install test --set couchbaseOperator.commandArgs.pod-create-timeout=30m0s --set couchbaseOperator.commandArgs.zap-level=debug couchbase/couchbase-operator --version 2.1.7

       Host Ports:    0/TCP, 0/TCP
          Command:
            couchbase-operator
            --pod-create-timeout=30m0s
            --zap-level=debug
          State:          Running
            Started:      Wed, 15 Sep 2021 16:09:27 -0700
      

      In addition, the values pod-creation-timeout=30m0s does not take effect when set.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          There's a bug here in the helm chart which causes the args to be repeated in deployment:

                  args:
                  - "--pod-create-timeout=30m0s"
                  args:
                  - "--zap-level=debug" 

          Same issue is in 2.2 so I will patch and back port. 

           

          tommie Tommie McAfee added a comment - There's a bug here in the helm chart which causes the args to be repeated in deployment:         args:         - "--pod-create-timeout=30m0s"         args:         - "--zap-level=debug" Same issue is in 2.2 so I will patch and back port.   

          Just pushed 2.1.18, should be fixed now

          tommie Tommie McAfee added a comment - Just pushed 2.1.18, should be fixed now

          hi Tommie McAfee
          Does this also fix the iss where pod-creation-timeout=30m0s does not take effect ?

          Thank you Tommie.

          tin.tran Tin Tran (Inactive) added a comment - hi Tommie McAfee Does this also fix the iss where pod-creation-timeout=30m0s does not take effect ? Thank you Tommie.

          Hey Tin, this just ensures that the timeout and debug can be set together.  If timeout is not taking effect that's a different issue.

           

          Verified 2.1.18

          helm install cbserver-dev  --set couchbaseOperator.commandArgs.pod-create-timeout=30m0s --set couchbaseOperator.commandArgs.zap-level=debug couchbase/couchbase-operator --version 2.1.18 --debug --dry-run

                  command:
                  - couchbase-operator
                  args:
                  - "--pod-create-timeout=30m0s"
                  - "--zap-level=debug" 

           

          tommie Tommie McAfee added a comment - Hey Tin, this just ensures that the timeout and debug can be set together.  If timeout is not taking effect that's a different issue.   Verified 2.1.18 helm install cbserver-dev  --set couchbaseOperator.commandArgs.pod-create-timeout=30m0s --set couchbaseOperator.commandArgs.zap-level=debug couchbase/couchbase-operator --version 2.1.18 --debug --dry-run         command:         - couchbase-operator         args:         - "--pod-create-timeout=30m0s"         - "--zap-level=debug"  
          anuj.sahni Anuj Sahni added a comment - - edited

          Is this fix also there in 2.2.103 helm chart? Here is how I am testing it from values.yaml file

           

          # couchbaseOperator is the controller for couchbase cluster
          couchbaseOperator:
            # additional command arguments will be translated to `--key=value`
            commandArgs:
              # pod creation timeout
              pod-create-timeout: 15m
              zap-log-level: info

          anuj.sahni Anuj Sahni added a comment - - edited Is this fix also there in 2.2.103 helm chart? Here is how I am testing it from values.yaml file   # couchbaseOperator is the controller for couchbase cluster couchbaseOperator:   # additional command arguments will be translated to `--key=value`   commandArgs:     # pod creation timeout     pod-create-timeout: 15m     zap-log-level: info

          Hi Tommie McAfee
          I can confirm the above that this issue also presents in 2.2.103

          Also, the documention for 2.2 says "zap-log-level" however for 2.1 it say "zap-level" so which one should we use?

          Thanks Tommie

          tin.tran Tin Tran (Inactive) added a comment - Hi Tommie McAfee I can confirm the above that this issue also presents in 2.2.103 Also, the documention for 2.2 says "zap-log-level" however for 2.1 it say "zap-level" so which one should we use? Thanks Tommie

          People

            tommie Tommie McAfee
            tin.tran Tin Tran (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty