Uploaded image for project: 'Couchbase Kafka Connector'
  1. Couchbase Kafka Connector
  2. KAFKAC-293

Scope And Collection in N1QL sink handler

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 4.1.8
    • None
    • 1

    Description

      The DMLs created in the N1QL sink handler are changed to use the collections and scopes. (It was just using the bucketName as the keySpace.)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Thanks Shahrzad Shirazi, at the moment, we probably need to support 6.x and 7.x. 7.x supports both formats. Or maybe I don't fully understand the change you're looking for in the connector? What was it you were trying to do that you could not?

          ingenthr Matt Ingenthron added a comment - Thanks Shahrzad Shirazi , at the moment, we probably need to support 6.x and 7.x. 7.x supports both formats. Or maybe I don't fully understand the change you're looking for in the connector? What was it you were trying to do that you could not?

          Hi Matt Ingenthron ,Thanks for the comment. The DMLs in the N1QL sink handler only use the bucket name as the keyspace. We wanted to see the data inserted into different scopes and collections. I added this improvement as I wanted to submit a new batch for it in Gerrit. The batch can be found at the following link. https://review.couchbase.org/c/kafka-connect-couchbase/+/179087
          In the code, we are creating N1QL DMLs and the only change needed was adding the scope and collection to the statements. And when we don't have any scopes and collections "_default" as collection and as the scope. (I can change it to "" as well if needed) Is there a problem in changing the DMLs in this way?

          shahrzad.shirazi Shahrzad Shirazi (Inactive) added a comment - - edited Hi Matt Ingenthron ,Thanks for the comment. The DMLs in the N1QL sink handler only use the bucket name as the keyspace. We wanted to see the data inserted into different scopes and collections. I added this improvement as I wanted to submit a new batch for it in Gerrit. The batch can be found at the following link. https://review.couchbase.org/c/kafka-connect-couchbase/+/179087 In the code, we are creating N1QL DMLs and the only change needed was adding the scope and collection to the statements. And when we don't have any scopes and collections "_default" as collection and as the scope. (I can change it to "" as well if needed) Is there a problem in changing the DMLs in this way?
          david.nault David Nault added a comment -

          Oops, didn't mean to resolve this yet.

          david.nault David Nault added a comment - Oops, didn't mean to resolve this yet.
          david.nault David Nault added a comment -

          Many thanks to Shahrzad Shirazi for this improvement.

          david.nault David Nault added a comment - Many thanks to Shahrzad Shirazi for this improvement.

          People

            david.nault David Nault
            shahrzad.shirazi Shahrzad Shirazi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty