Details
-
Bug
-
Resolution: Fixed
-
Major
-
4.5.1
-
None
-
Untriaged
-
Unknown
Description
As seen in nightly coverage testing, test EPStoreEvictionTest.GetKeyStatsEjected fails on some environments / configurations as it is incorrectly comparing arguments as char* instead of std::string. As a consequence it only passes if the compiler performs a string literal optimisation:
[ RUN ] FullAndValueEviction/EPStoreEvictionTest.GetKeyStatsEjected/0
|
/home/couchbase/jenkins/workspace/memcached-nightly-coverage-watson/ep-engine/tests/module_tests/evp_store_test.cc:190: Failure
|
Value of: msg
|
Actual: 0x80d9b0
|
Expected: "Ejected."
|
Which is: 0x801bd3
|
[ FAILED ] FullAndValueEviction/EPStoreEvictionTest.GetKeyStatsEjected/0, where GetParam() = "value_only" (76 ms)
|
Instead we should ensure they are compared as std::string
Attachments
Issue Links
| For Gerrit Dashboard: MB-19807 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 64645,2 | MB-19807: EPStoreEvictionTest.GetKeyStatsEjected incorrectly compares strings as ptrs | watson | ep-engine | Status: MERGED | +2 | +1 |
| 64722,1 | Merge remote-tracking branch 'couchbase/watson' into master | master | ep-engine | Status: ABANDONED | 0 | 0 |
| 64767,1 | Merge remote-tracking branch 'couchbase/watson' | master | ep-engine | Status: MERGED | +2 | +1 |