Details
-
Bug
-
Resolution: Fixed
-
Minor
-
4.1.2
-
None
-
Untriaged
-
Unknown
Description
Merging sherlock to watson triggered a failure as this stat goes away. Looking at the sherlock branch it appears a previous merge dropped the call to collect this stat from the connection map.
- 3.0.x has it https://github.com/couchbase/ep-engine/blob/3.0.x/src/ep_engine.cc#L3984
- sherlock it's gone https://github.com/couchbase/ep-engine/blob/sherlock/src/ep_engine.cc#L4084
- watson has it https://github.com/couchbase/ep-engine/blob/watson/src/ep_engine.cc#L4234
In watson it appears ep_testsuite is more sensitive to the stat going away, hence the sherlock->watson merge triggers a failure, yet sherlock doesn't fail.
ee1129699abfbbc4485f3c2ec2a9c4a53eb8a478 appears to have removed the stat call.
Attachments
For Gerrit Dashboard: MB-20307 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
66284,4 | MB-20307: Re-enable dcp ep_dcp_dead_conn_count | sherlock | ep-engine | Status: MERGED | +2 | +1 |
66325,11 | Merge remote-tracking branch 'couchbase/sherlock' into 'couchbase/watson' | watson | ep-engine | Status: MERGED | +2 | +1 |
66453,4 | Merge remote-tracking branch 'couchbase/watson' into 'couchbase/master' | master | ep-engine | Status: ABANDONED | -1 | +1 |
66487,4 | Add unmerged-commits.py | master | ep-engine | Status: MERGED | +2 | +1 |
66492,3 | Merge remote-tracking branch 'couchbase/watson' into 'couchbase/master' | master | ep-engine | Status: MERGED | +2 | +1 |