Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-20497

golang net/http package honours HTTP_PROXY / HTTPS_PROXY Environment Variables

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.0.0
    • 4.0.0, 4.1.0, 4.1.1, 4.1.2, 4.5.0
    • ns_server
    • Untriaged
    • Unknown

    Description

      Similar to curl/libcurl in MB-15438, the net/http package used by Couchbase's golang modules honours the proxy-related HTTP_PROXY and HTTPS_PROXY environment variables.

      This definitely affects the communication between indexer and projector, but can in theory affect any golang module that uses net/http.

      There are a few potential issues. If the proxy expects authentication then the indexer will be unable to communicate with the projector. If it doesn't and the communication successfully takes place via the proxy, then we will be potentially transferring a lot of inter-node data via a third-party, probably on a different subnet, which will likely have an effect on performance.

      The fix is similar to MB-15438 - making sure the environment is sane before launching the golang module(s) from ns_server's ns_ports_setup.erl. If there's any chance we will use HTTPS as well as HTTP in the future then both variables should be cleared.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              malarky Chris Malarky
              malarky Chris Malarky
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty