Loading...

XML

Word

Printable

In the for loop at http://src.couchbase.org/source/xref/4.5.0/ep-engine/src/failover-table.cc#59
table.erase() increments the iterator and we increment the iterator in the for loop as well. Hence, by double incrementing the iterator we will not remove all the entries that are supposed to be removed.

relates to

MB-19635 Offline upgrade from 2.5 to any 3.x or 4.x release results in potential data loss

MB-20852 set_vbucket is raceful with other set_vbucket invocations and with sync vbucket deletions (and likely with lots of other stuff)

For Gerrit Dashboard: MB-20822
#	Subject	Branch	Project	Status	CR	V
67481,6	MB-20822: Erase all diverged branch entries correctly in failover table	watson	ep-engine	Status: MERGED	+2	+1
67702,8	MB-20822: When loading persisted failovers, remove any erroneous entries	watson	ep-engine	Status: MERGED	+2	+1
68209,1	Merge remote-tracking branch 'couchbase/watson'	master	ep-engine	Status: MERGED	+2	+1
68563,1	Merge remote-tracking branch 'couchbase/watson'	master	ep-engine	Status: MERGED	+2	+1
69132,3	MB-20822: Print correct value for vb_%d:num_erroneous_entries_erased	watson	ep-engine	Status: MERGED	+2	+1
69803,1	Merge remote-tracking branch 'couchbase/watson'	master	ep-engine	Status: MERGED	+2	+1
79549,4	MB-24861: Remove UUID:0 from vbucket_state::reset()	master	kv_engine	Status: MERGED	+2	+1