Details
-
Task
-
Resolution: Fixed
-
Critical
-
4.1.2, 4.5.1
-
None
Description
During investigation of MB-21475 it was noted that we still have a number of abort() calls in the codebase. The intent was to replace such uses with throwing exceptions (see https://github.com/couchbase/memcached/blob/master/docs/ErrorHandling.md) however while the cb_assert() calls were addressed, abort was not
We should audit the use of abort, and remove where possible, replacing with exceptions (e.g. std::logic_error.
Attachments
Issue Links
- relates to
-
MB-21475 memcached abort during bucket deletion when deleting Items from VBucketMemoryDeletionTask
- Closed
For Gerrit Dashboard: MB-21540 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
69371,5 | MB-21540: Refactor VBucketVisitor to remove need for abort | watson | ep-engine | Status: MERGED | +2 | +1 |
69372,5 | MB-21540: DCP: Replace abort() with exceptions | watson | ep-engine | Status: MERGED | +2 | +1 |
69373,4 | MB-21540: Convert ep_time.c -> ep_time.cc | watson | ep-engine | Status: MERGED | +2 | +1 |
69374,3 | MB-21540: ep_time.cc: Replace abort() with std::logic_error | watson | ep-engine | Status: MERGED | +2 | +1 |
69375,3 | MB-21540: tapconnection: Replace abort() with exceptions | watson | ep-engine | Status: MERGED | +2 | +1 |
69376,11 | MB-21540: ep-engine: Remove abort() | watson | ep-engine | Status: MERGED | +2 | +1 |
69838,1 | Merge remote-tracking branch 'couchbase/watson' | master | ep-engine | Status: MERGED | +2 | +1 |
69839,1 | Merge remote-tracking branch 'couchbase/watson' | master | ep-engine | Status: MERGED | +2 | +1 |
70019,1 | Merge remote-tracking branch 'couchbase/watson' | master | ep-engine | Status: MERGED | +2 | +1 |
70155,1 | Merge remote-tracking branch 'couchbase/watson' | master | ep-engine | Status: MERGED | +2 | +1 |