Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-22227

ep-engine: coverity warnings in KVShard constructor

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 5.0.0
    • .master
    • couchbase-bucket
    • Untriaged
    • Unknown

    Description

      See below coverity report:

      ** CID 159584:    (UNINIT_CTOR)
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
       
       
      ________________________________________________________________________________________________________
      *** CID 159584:    (UNINIT_CTOR)
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
      54         if (epstore) {
      55             /* We want Flusher and BgFetcher only in case of epstore not
      56                ephemeral store */
      57             flusher = new Flusher(epstore, this, commitInterval);
      58             bgFetcher = new BgFetcher(epstore, this, stats);
      59         }
         CID 159584:    (UNINIT_CTOR)
         Non-static class member "bgFetcher" is not initialized in this constructor nor in any functions that it calls.
      60     }
      61     
      62     KVShard::~KVShard() {
      63         if (flusher->state() != stopped) {
      64             flusher->stop(true);
      65             LOG(EXTENSION_LOG_WARNING, "Terminating flusher while it is in %s",
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
      54         if (epstore) {
      55             /* We want Flusher and BgFetcher only in case of epstore not
      56                ephemeral store */
      57             flusher = new Flusher(epstore, this, commitInterval);
      58             bgFetcher = new BgFetcher(epstore, this, stats);
      59         }
         CID 159584:    (UNINIT_CTOR)
         Non-static class member "roUnderlying" is not initialized in this constructor nor in any functions that it calls.
      60     }
      61     
      62     KVShard::~KVShard() {
      63         if (flusher->state() != stopped) {
      64             flusher->stop(true);
      65             LOG(EXTENSION_LOG_WARNING, "Terminating flusher while it is in %s",
      /ep-engine/src/kvshard.cc: 60 in KVShard::KVShard(unsigned short, KVBucketIface &)()
      54         if (epstore) {
      55             /* We want Flusher and BgFetcher only in case of epstore not
      56                ephemeral store */
      57             flusher = new Flusher(epstore, this, commitInterval);
      58             bgFetcher = new BgFetcher(epstore, this, stats);
      59         }
         CID 159584:    (UNINIT_CTOR)
         Non-static class member "bgFetcher" is not initialized in this constructor nor in any functions that it calls.
      60     }
      61     
      62     KVShard::~KVShard() {
      63         if (flusher->state() != stopped) {
      64             flusher->stop(true);
      65             LOG(EXTENSION_LOG_WARNING, "Terminating flusher while it is in %s",
       
      ** CID 159583:  Uninitialized members  (UNINIT_CTOR)
      /ep-engine/src/checkpoint.h: 622 in CheckpointManager::CheckpointManager(EPStats &, unsigned short, CheckpointConfig &, long, unsigned long, unsigned long, std::shared_ptr<Callback<unsigned short>>)()
       
       
      ________________________________________________________________________________________________________
      *** CID 159583:  Uninitialized members  (UNINIT_CTOR)
      /ep-engine/src/checkpoint.h: 622 in CheckpointManager::CheckpointManager(EPStats &, unsigned short, CheckpointConfig &, long, unsigned long, unsigned long, std::shared_ptr<Callback<unsigned short>>)()
      616             pCursorPreCheckpointId(0),
      617             flusherCB(cb) {
      618             LockHolder lh(queueLock);
      619             addNewCheckpoint_UNLOCKED(1, lastSnapStart, lastSnapEnd);
      620                 registerCursor_UNLOCKED("persistence", 1, false,
      621                                         MustSendCheckpointEnd::NO);
         CID 159583:  Uninitialized members  (UNINIT_CTOR)
         Non-static class member "lastClosedCheckpointId" is not initialized in this constructor nor in any functions that it calls.
      622         }
      623     
      624         ~CheckpointManager();
      625     
      626         uint64_t getOpenCheckpointId_UNLOCKED();
      627         uint64_t getOpenCheckpointId();
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            drigby Dave Rigby (Inactive)
            drigby Dave Rigby (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty