Details
-
Bug
-
Resolution: Won't Do
-
Major
-
None
-
5.0.0
-
None
-
Untriaged
-
Windows 64-bit
-
Unknown
Description
when we're building shared objects we need to add the declspec attribute on all of the template stuff we're using:
c:\jenkins\workspace\memcached-gerrit-master\label\windows\phosphor\include\phosphor\trace_log.h(448) : warning C4251: 'phosphor::TraceLog::thread_names' : class 'std::unordered_map<uint64_t,std::string,std::hash<unsigned __int64>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>' needs to have dll-interface to be used by clients of class 'phosphor::TraceLog'