Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-22387

Make (statically) return type of VBucket::addTempStoredValue to just NOMEM or BG_FETCH

    XMLWordPrintable

Details

    Description

      VBucket::addTempStoredValue can only return two possible results - NoMem or BgFetch; however it's return type is an enum with 6 values:

      enum class AddStatus : uint16_t {
          Success, //!< Add was successful.
          NoMem, //!< No memory for operation
          Exists, //!< Did not update -- item exists with this key
          UnDel, //!< Undeletes an existing dirty item
          AddTmpAndBgFetch, //!< Create a tmp item and schedule a bg metadata fetch
          BgFetch //!< Schedule a bg metadata fetch to process ADD op
      };
      

      We should change it to statically return just a binary type.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            drigby Dave Rigby (Inactive)
            manu Manu Dhundi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty