Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-22422

Fix corner cases for secondary key length checks in GSI

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 5.0.0
    • 4.5.0
    • secondary-index
    • None
    • Untriaged
    • No

    Description

      Some additional fixes needed on top of fixes for MB-22409:

      1. MOI array index insert path should create NewSecondaryIndexEntry with isArray as false
      2. Array secondary entry size check should be against maxArrayKeyBufferLength in index_entry L131
      3. Add additional 2 bytes in buffer for optional count for duplicate array index
      4. Scan co-ordinator secnBufPool should be increased with ENCODE_BUF_SAFE_PAD
      5. Remove crashonerror / checkdbfatal errors for non-storage operations in slice writers.
      6. Fix logging in array.go. Length should be logged not the key.
      7. Remove duplicate logging in fdb/moi slice writers as it is already logged in array.go

      These above three fixes will complete the fix for MB-22409. These fixes are more code change so were not done for the hotfix.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              prathibha Prathibha Bisarahalli (Inactive)
              prathibha Prathibha Bisarahalli (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty