Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-22513

Check if Hash bucket is calculated multiple times (from the key) in the calls to hash table functions

    XMLWordPrintable

Details

    Description

      Example:
      HashTable::unlocked_addNewStoredValue() calculates hash bucket_num from the key.
      (int bucket_num = getBucketForHash(itm.getKey().hash()))

      But the callers of the functions have calculated the hash bucket before. We could pass it as a param rather than recalculating it.

      There maybe many more cases like this in the hash table

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            oliver.downard Oliver Downard (Inactive)
            manu Manu Dhundi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty