Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-23266

ep-engine configuration.json "dynamic" flag is backwards

    XMLWordPrintable

Details

    • Triaged
    • No

    Description

      genconfig.cc uses the "dynamic" attribute of objects in configuration.json to determine if setters should be generated - logically true would indicate that something is not read only; this is not the case.

      genconfig.cc

      static bool isReadOnly(cJSON *o) {
          cJSON *i = cJSON_GetObjectItem(o, "dynamic");
          if (i == NULL || i->type == cJSON_False) {
              return false;
          }
       
          cb_assert(i->type == cJSON_True);
          return true;
      }
      

      In reality, "dynamic": false or a missing dynamic flag is used to indicate that something is not read only. "dynamic":true is never used, but would mark the parameter as read only, and setters would not be generated.

      Attachments

        Activity

          People

            sriram Sriram Ganesan (Inactive)
            james.harrison James Harrison (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty